Skip to content

test(node): Run Prisma docker containers via test runner #15402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 13, 2025
Merged

test(node): Run Prisma docker containers via test runner #15402

merged 3 commits into from
Feb 13, 2025

Conversation

@timfish
Copy link
Collaborator

@timfish timfish commented Feb 13, 2025

This PR migrates the prisma tests to use the withDockerCompose option on the test runner.

This means:

  • Docker is only required if you're running tests that actually use docker
  • Containers are automatically cleaned up after tests complete

@timfish timfish marked this pull request as ready for review February 13, 2025 12:58
@timfish timfish requested a review from Lms24 February 13, 2025 13:01
@codecov
Copy link

codecov bot commented Feb 13, 2025 •
edited
Loading

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
249 2 247 7
View the top 2 failed test(s) by shortest run time 
Prisma ORM v6 Tests CJS - should instrument PostgreSQL queries from Prisma ORM
Stack Traces | 15s run time 
Error: thrown: "Exceeded timeout of 15000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."
    at .../tracing/prisma-orm-v6/test.ts:9:3
    at _dispatchDescribe (.../jest-circus/build/index.js:98:26)
    at describe (.../jest-circus/build/index.js:60:5)
    at Object.<anonymous> (.../tracing/prisma-orm-v6/test.ts:8:1)
    at Runtime._execModule (.../jest-runtime/build/index.js:1646:24)
    at Runtime._loadModule (.../jest-runtime/build/index.js:1185:12)
    at Runtime.requireModule (.../jest-runtime/build/index.js:1009:12)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:13)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at runTestInternal (.../jest-runner/build/runTest.js:389:16)
Prisma ORM v5 Tests CJS - should instrument PostgreSQL queries from Prisma ORM
Stack Traces | 15s run time 
Error: thrown: "Exceeded timeout of 15000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."
    at .../tracing/prisma-orm-v5/test.ts:8:3
    at _dispatchDescribe (.../jest-circus/build/index.js:98:26)
    at describe (.../jest-circus/build/index.js:60:5)
    at Object.<anonymous> (.../tracing/prisma-orm-v5/test.ts:7:1)
    at Runtime._execModule (.../jest-runtime/build/index.js:1646:24)
    at Runtime._loadModule (.../jest-runtime/build/index.js:1185:12)
    at Runtime.requireModule (.../jest-runtime/build/index.js:1009:12)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:13)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at runTestInternal (.../jest-runner/build/runTest.js:389:16)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Lms24
Lms24 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tim!

@Lms24 Lms24 merged commit b433821 into develop Feb 13, 2025
31 checks passed
@Lms24 Lms24 deleted the timfish/test/run-prisma-docker-via-runner branch February 13, 2025 13:33
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timfish @Lms24